Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Wrong setting link in the notice after activation #169

Merged
merged 4 commits into from
Feb 19, 2020
Merged

Fix: Wrong setting link in the notice after activation #169

merged 4 commits into from
Feb 19, 2020

Conversation

dinhtungdu
Copy link
Contributor

@dinhtungdu dinhtungdu commented Jan 17, 2020 •
edited
Loading

Description of the Change

Change setting link after activation to the correct one.

Verification Process

The setting link after activation should be: /wp-admin/admin.php?page=classifai_settings

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes #166, closes #99

@dinhtungdu dinhtungdu self-assigned this Jan 17, 2020
@jeffpaul jeffpaul added this to the 1.5.0 milestone Jan 17, 2020
@jeffpaul jeffpaul added the type:bug Something isn't working. label Jan 17, 2020
@dinhtungdu dinhtungdu mentioned this pull request Jan 21, 2020
Closed
@dinhtungdu
Copy link
Contributor Author

Resolves #99

@jeffpaul jeffpaul merged commit 2111c68 into develop Feb 19, 2020
@jeffpaul jeffpaul deleted the fix/setting-link-166 branch March 5, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanwelcher ryanwelcher ryanwelcher approved these changes

Assignees

@dinhtungdu dinhtungdu

Labels
type:bug Something isn't working.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Wrong setting link in the notice after activation Duplicate notification when saving Registration Key
3 participants
@dinhtungdu @ryanwelcher @jeffpaul