Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: WP Admin menu icon #173

Merged
merged 3 commits into from
Feb 24, 2020
Merged

Add: WP Admin menu icon #173

merged 3 commits into from
Feb 24, 2020

Conversation

dinhtungdu
Copy link
Contributor

Description of the Change

Add admin menu icon for ClassifAI menu.

Alternate Designs

Use gray icon instead of red.

Benefits

ClassifAI menu is easier to reach and distinguish.

Possible Drawbacks

n/a

Verification Process

  1. Login to admin.
  2. See new icon next to ClassifAI menu.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Close #130

@dinhtungdu dinhtungdu self-assigned this Jan 21, 2020
@jeffpaul jeffpaul added this to the 1.5.0 milestone Jan 22, 2020
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Jan 22, 2020
@jeffpaul jeffpaul removed their request for review January 22, 2020 15:29
@jeffpaul jeffpaul self-requested a review February 19, 2020 05:58
jeffpaul
jeffpaul requested changes Feb 19, 2020
View reviewed changes
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After further review, we're going to pull all these settings into a default WP Admin tools or settings submenu option instead. I'll work on further defining that change in a separate issue, but for now we can probably close this PR and related issue.

@jeffpaul jeffpaul merged commit 6de7785 into develop Feb 24, 2020
@jeffpaul jeffpaul deleted the fix/130-menu-icon branch March 5, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffpaul jeffpaul jeffpaul requested changes

@ryanwelcher ryanwelcher ryanwelcher approved these changes

Assignees

@dinhtungdu dinhtungdu

Labels
type:enhancement New feature or request.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Add WP Admin menu icon
3 participants
@dinhtungdu @ryanwelcher @jeffpaul