Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax issue on line 29 #181

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Syntax issue on line 29 #181

merged 2 commits into from
Feb 19, 2020

Conversation

kant
Copy link
Contributor

@kant kant commented Feb 12, 2020

There is no break on code, so, no collateral damage threat

Description of the Change

Fixed typo on line 29

Alternate Designs

Benefits

Better documentation (at final of the road)

Possible Drawbacks

There is no drawbacks, no collateral damage

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

There is no previous PR associated or related

@kant kant requested review from jeffpaul and helen February 12, 2020 14:16
@jeffpaul jeffpaul added the needs:documentation This requires documentation. label Feb 12, 2020
@jeffpaul jeffpaul added this to the 1.5.0 milestone Feb 12, 2020
jeffpaul
jeffpaul approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catches @kant, looks good to me!

@ryanwelcher
Copy link
Contributor

Looks good to me as well. Thanks for putting this together @kant

@jeffpaul jeffpaul merged commit 438307a into 10up:develop Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffpaul jeffpaul jeffpaul approved these changes

@helen helen Awaiting requested review from helen

Assignees

@kant kant

Labels
needs:documentation This requires documentation.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kant @ryanwelcher @jeffpaul