Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move doc deploy action to the release workflow #192

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

helen
Copy link
Contributor

@helen helen commented Mar 5, 2020

Description of the Change

Moves the doc build/deployment to the same workflow as the release to stable, since both run on master and are a signal of an impending new release. Realized this as I was changing the doc workflow to go back to running on master instead of develop. Also fixes a warning about version being deprecated in favor of node-version.

Alternate Designs

Leaving as-is, which is more resource intensive as it spins up two machines and runs npm install on both.

Benefits

Faster workflow run, less maintenance.

Possible Drawbacks

If we decide later they shouldn't run on the same trigger we'll have to split it back out.

Verification Process

n/a, basically hoping it'll work.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

See #191

Changelog Entry

n/a

Since all of this happens on merge to master, which is a signal to build a new release, they should all just run as one to save time and resources.
@jeffpaul jeffpaul added this to the 1.6.0 milestone Mar 6, 2020
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, good thinking on combining these as well!

@helen helen merged commit 8e17d33 into develop Mar 6, 2020
@jeffpaul jeffpaul modified the milestones: 1.6.0, 1.5.1 Mar 6, 2020
@jeffpaul jeffpaul deleted the fix/combine-master-actions branch October 21, 2020 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants