Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude vendor library and POT file #212

Merged
merged 4 commits into from
May 11, 2022
Merged

Exclude vendor library and POT file #212

merged 4 commits into from
May 11, 2022

Conversation

dinhtungdu
Copy link
Contributor

Description of the Change

Remove pot file and vendor library from git. Update the release workflow to build the language file and install composer packages on release.

Alternate Designs

N/A

Benefits

Cleaner code base.

Possible Drawbacks

N/A

Verification Process

Check the stable branch after running updated release workflow to see language file and plugin-update-checker library.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Fixes #64

Changelog Entry

N/A

@dinhtungdu dinhtungdu requested a review from helen June 5, 2020 08:48
@dinhtungdu dinhtungdu self-assigned this Jun 5, 2020
@jeffpaul jeffpaul added this to the 1.6.0 milestone Jun 5, 2020
@jeffpaul jeffpaul requested a review from ryanwelcher June 5, 2020 20:22
@dinhtungdu dinhtungdu changed the title Exclude vendor library or POT file Exclude vendor library and POT file Sep 29, 2020
@jeffpaul
Copy link
Member

We may want to look at bumping the update checker to its latest v4.10 as well as possibly leveraging https://github.com/Automattic/jetpack-autoloader to help with conflicts with other plugins using the same update checker but different version (e.g., https://github.com/10up/10up-experience). Punting this to 1.7.0 to allow for more time to work on this while we in parallel work to releasing 1.6.0.

@jeffpaul jeffpaul modified the milestones: 1.6.0, 1.7.0 Sep 29, 2020
@jeffpaul jeffpaul mentioned this pull request Jul 7, 2021
21 tasks
@jeffpaul
Copy link
Member

jeffpaul commented Jul 7, 2021

Note that this will likely mean updates to the release instructions in CONTRIBUTING.md as well the 1.7.0 release issue steps.

@helen helen modified the milestones: 1.7.0, Future Release Aug 26, 2021
@jeffpaul jeffpaul requested review from a team and iamdharmesh and removed request for helen, ryanwelcher and a team May 10, 2022 02:37
iamdharmesh
iamdharmesh previously approved these changes May 10, 2022
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR @dinhtungdu

@dinhtungdu
Copy link
Contributor Author

Note that this will likely mean updates to the release instructions in CONTRIBUTING.md as well the #289.

@jeffpaul I updated the release instruction per your suggestion.

@jeffpaul jeffpaul modified the milestones: Future Release, 1.8.0 May 11, 2022
@jeffpaul jeffpaul merged commit 0687031 into develop May 11, 2022
@jeffpaul jeffpaul deleted the fix/64 branch May 11, 2022 12:55
@jeffpaul jeffpaul modified the milestones: 1.8.0, 1.7.2 Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build/release: Do not commit vendor library or POT file
4 participants