-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude vendor library and POT file #212
Conversation
We may want to look at bumping the update checker to its latest v4.10 as well as possibly leveraging https://github.com/Automattic/jetpack-autoloader to help with conflicts with other plugins using the same update checker but different version (e.g., https://github.com/10up/10up-experience). Punting this to |
Note that this will likely mean updates to the release instructions in CONTRIBUTING.md as well the 1.7.0 release issue steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR @dinhtungdu
@jeffpaul I updated the release instruction per your suggestion. |
Description of the Change
Remove pot file and vendor library from git. Update the release workflow to build the language file and install composer packages on release.
Alternate Designs
N/A
Benefits
Cleaner code base.
Possible Drawbacks
N/A
Verification Process
Check the stable branch after running updated release workflow to see language file and
plugin-update-checker
library.Checklist:
Applicable Issues
Fixes #64
Changelog Entry
N/A