Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: WPAcceptance test cases #215

Merged
merged 25 commits into from
Oct 20, 2020
Merged

Add: WPAcceptance test cases #215

merged 25 commits into from
Oct 20, 2020

Conversation

dinhtungdu
Copy link
Contributor

@dinhtungdu dinhtungdu commented Jul 13, 2020

Description of the Change

This PR:

  • Updates WP version of the testing snapshot to latest.
  • Add nightly snapshot to test against the development version of WP.
  • Adds more test cases to verify plugin functionalities.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#205

Changelog Entry

@jeffpaul jeffpaul added this to the 1.6.0 milestone Jul 13, 2020
@dinhtungdu dinhtungdu marked this pull request as ready for review July 16, 2020 02:50
@jeffpaul jeffpaul requested a review from helen July 16, 2020 14:57
@jeffpaul
Copy link
Member

@dinhtungdu let's bump the snapshot to WordPress 5.5 to cover that core upgrade coming this week

@jeffpaul
Copy link
Member

jeffpaul commented Sep 29, 2020

  • switch to using GitHub Actions
  • add daily cron

@helen
Copy link
Contributor

helen commented Sep 29, 2020

Next steps: @dinhtungdu will be switching to GitHub Actions as the runner and setting up an additional daily cron run (especially useful for nightlies).

@helen helen mentioned this pull request Sep 29, 2020
6 tasks
@dinhtungdu
Copy link
Contributor Author

dinhtungdu commented Sep 30, 2020

I switched PHPUnit and WPAcceptance tests to GitHub Actions. Daily cron is set up as well. WPAcceptance test is failing because WPsnapshots has a bug with nightly version which is addressed here: 10up/wpsnapshots#78.

@jeffpaul
Copy link
Member

@dinhtungdu maybe we revert the nightly part in here so this PR can get merged in and add that back in once it's available in WP Snapshots?

@dinhtungdu
Copy link
Contributor Author

@jeffpaul Update and GH actions are passing now. This is ready to be merged.

@jeffpaul jeffpaul merged commit 21981c8 into develop Oct 20, 2020
@jeffpaul jeffpaul deleted the fix/205 branch November 10, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants