Add better error handling for manual scanning of alt text or image tags #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror objects if anything goes wrong. Modify our JS that makes these API requests to ensure if something goes wrong, we output that error message to the user and remove the spinner.
This was referenced Oct 16, 2020
Merged
dinhtungdu
reviewed
Oct 17, 2020
src/js/media.js
Outdated
Comment on lines
32
to
40
| const errorObj = get( error, 'responseJSON', { | ||
| code: 'unknown_error', | ||
| message: __( 'An unknown error occurred.', 'classifai' ), | ||
| } ); | ||
| spinner.style.display = 'none'; | ||
| spinner.classList.remove( 'is-active' ); | ||
| button.textContent = __( 'Error', 'classifai' ); | ||
| errorContainer.style.display = 'inline-block'; | ||
| errorContainer.textContent = errorObj.message; |
There was a problem hiding this comment.
How do users retry scanning after failing (due to network issue for example)?
There was a problem hiding this comment.
@dinhtungdu Thanks for the review! Just pushed a fix for this, so if an error happens, we make sure the button is no longer disabled, so it can be clicked again
added 4 commits
October 19, 2020 12:29
…escan can happen again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Make sure our requests to generate alt text or image tags return a WP_Error object if something goes wrong. Currently we are returning those in a few instances but not in every instance.
In our javascript that makes these requests, if the response fails, check to see if we have error details and if so, show that error message. If we don't have error details, output a default error message. Also, make sure the spinner is removed so it doesn't appear like things are still processing.
Alternate Designs
None
Benefits
If a request fails, we provide feedback to the user about what went wrong.
Possible Drawbacks
None
Verification Process
Checklist:
Applicable Issues
#230