Fix: Smart cropping for existing images #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dinhtungdu I cannot check the smart cropping as I needs to be on a remote server. Please advise on how you would like me to proceed. |
dinhtungdu
changed the title
dinhtungdu
suggested changes
Oct 28, 2020
| // Screen returns null on the Media library page. | ||
| if ( ! $screen ) { | ||
| $alt_tags_text = empty( get_post_meta( $post->ID, '_wp_attachment_image_alt', true ) ) ? __( 'Generate', 'classifai' ) : __( 'Rescan', 'classifai' ); | ||
| $image_tags_text = empty( wp_get_object_terms( $post->ID, 'classifai-image-tags' ) ) ? __( 'Generate', 'classifai' ) : __( 'Rescan', 'classifai' ); | ||
| $smart_crop_text = empty( get_transient( 'classifai_azure_computer_vision_smart_cropping_latest_response' ) ) ? __( 'Generate', 'classifai' ) : __( 'Rescan', 'classifai' ); |
There was a problem hiding this comment.
Suggested change
| $smart_crop_text = empty( get_transient( 'classifai_azure_computer_vision_smart_cropping_latest_response' ) ) ? __( 'Generate', 'classifai' ) : __( 'Rescan', 'classifai' ); | |
| $smart_crop_text = empty( get_transient( 'classifai_azure_computer_vision_smart_cropping_latest_response' ) ) ? __( 'Generate', 'classifai' ) : __( 'Regenerate', 'classifai' ); |
There was a problem hiding this comment.
@dinhtungdu I've updated the above wording
|
@dinhtungdu I've just noticed I've added this to the media modal:
But not to the media edit page:
I'll get this done also |
|
@dinhtungdu I've also added the functionality to the media edit page |
dinhtungdu
reviewed
Oct 28, 2020
| $settings = get_option( 'classifai_computer_vision' ); | ||
| $captions = get_post_meta( $post->ID, '_wp_attachment_image_alt', true ) ? __( 'Rescan Alt Text', 'classifai' ) : __( 'Scan Alt Text', 'classifai' ); | ||
| $tags = ! empty( wp_get_object_terms( $post->ID, 'classifai-image-tags' ) ) ? __( 'Rescan Tags', 'classifai' ) : __( 'Generate Tags', 'classifai' ); | ||
| $smart_crop = get_transient( 'classifai_azure_computer_vision_smart_cropping_latest_response' ) ? __( 'Regenerate Smart Crop', 'classifai' ) : __( 'Generate Smart Crop', 'classifai' ); |
There was a problem hiding this comment.
another wording comment for this, "Smart Crop" is not straightforward for end-users. May be "Generate Smart Thumbnail" or just "Generate Thumbnail"?
There was a problem hiding this comment.
@dinhtungdu changed as requested to "Generate Smart Thumbnail"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds the ability to Smart Crop existing images in WP Admin. It relates to #213.
Scope/Approach
Benefits
Allows Smart cropping of pre-existing images from the media attachments screen.
Verification Process
NOTE: I could not check the last step as this needs to be done on a remote server. I was able to track the functionality through the code.
Checklist:
Applicable Issues
#213