Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing TODO from https://github.com/10up/classifai/issues/260 ComputerVision::reset_settings() #264

Merged
merged 8 commits into from
May 7, 2021

Commits on Jan 24, 2021

  1. Addressing TODO from 10up#260

    I looked the serialized array data in the database for what is there when the plugin is activated upon a fresh install and modelled the reset_settings() method off of that data and the includes/Classifai/Providers/Watson/NLU.php reset_settings() method.
    
    Not sure if there is more that you are looking for or if you would also like a button on this page that triggers an event to reset the settings. If there is something like that you are looking for please let me know :)
    Connor Smyth committed Jan 24, 2021
    Configuration menu
    Copy the full SHA
    9357cf5 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. Addressing comment about further improving PR

    Created a get_default_settings() method that returns the default settings, then used that function in reset_settings() method and setup_fields_sections() method
    Connor Smyth committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    d469a6d View commit details
    Browse the repository at this point in the history
  2. Responding to PHPCS linting feedback and fixing errors in add_setting…

    …s_field() arguments
    Connor Smyth committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    3205866 View commit details
    Browse the repository at this point in the history
  3. Responding to PHPCS linting feedback

    Connor Smyth committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    f8c5641 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. Configuration menu
    Copy the full SHA
    38340ac View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. Configuration menu
    Copy the full SHA
    11f64cb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    975b089 View commit details
    Browse the repository at this point in the history
  3. fix: cs

    dinhtungdu committed May 7, 2021
    Configuration menu
    Copy the full SHA
    2ecfa98 View commit details
    Browse the repository at this point in the history