Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Undefined ClassifAI Error Meta #286

Merged

Conversation

junaidbhura
Copy link
Contributor

Description of the Change

This fixes the issue raised in #285

An additional check is added to look for the existence of a variable before checking its property.

Alternate Designs

Benefits

Possible Drawbacks

None.

Verification Process

This has been tested on a project, and verified as working.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Fixes #285

Changelog Entry

@junaidbhura junaidbhura changed the title fix undefined classifai error meta Fix: Undefined ClassifAI Error Meta Jun 3, 2021
@jeffpaul jeffpaul requested a review from dinhtungdu June 4, 2021 01:25
@jeffpaul jeffpaul added this to the 1.7.0 milestone Jun 4, 2021
@jeffpaul jeffpaul added the type:bug Something isn't working. label Jun 4, 2021
@jeffpaul jeffpaul merged commit d6dfdb8 into 10up:develop Jun 7, 2021
@junaidbhura junaidbhura deleted the fix/undefined-classifai-error-meta branch June 10, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaScript error in Block Editor when ClassifAI has not been set up correctly
3 participants