Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin assets #293

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Update plugin assets #293

merged 2 commits into from
Jul 23, 2021

Conversation

jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented Jul 21, 2021

Description of the Change

This PR adds in missing banner images (to display when someone clicks the View details link from the WP Admin plugin screen) and updates the icon images to match. Note this is currently WIP while I await an updated icon.svg file, I'll update the PR when that's available.

Alternate Designs

n/a

Benefits

Ensures we properly display ClassifAI imagery where possible.

Possible Drawbacks

none identified

Verification Process

  1. Open wp-admin/plugins.php
  2. Click "View details" next to installed ClassifAI plugin
  3. View updated images

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

n/a

Changelog Entry

### Changed
- Updated plugin icon, added banner (props [@blancahong](https://profiles.wordpress.org/blancahong/)).

@jeffpaul jeffpaul added this to the 1.7.0 milestone Jul 21, 2021
@jeffpaul jeffpaul self-assigned this Jul 21, 2021
@jeffpaul jeffpaul marked this pull request as ready for review July 22, 2021 14:49
@jeffpaul jeffpaul requested a review from dinhtungdu July 22, 2021 14:50
@jeffpaul jeffpaul merged commit 4aadada into develop Jul 23, 2021
@jeffpaul jeffpaul deleted the update/assets branch July 23, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants