Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide Scan Text checkbox if OCR is disabled #299

Merged
merged 2 commits into from
Aug 18, 2021
Merged

fix: hide Scan Text checkbox if OCR is disabled #299

merged 2 commits into from
Aug 18, 2021

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Aug 9, 2021

Resolves #279

Description of the Change

Hides the 'Scan Text' checkbox field if OCR is disabled.

Verification Process

How did you verify that all new functionality works as expected?
Enabled/Disabled OCR setting to verify if the Scan Text checkbox was shown or hidden.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

Fix - Hides the Scan Text checkbox field on the media edit page when OCR is disabled

@jeffpaul jeffpaul added this to the 1.7.0 milestone Aug 9, 2021
@jeffpaul jeffpaul added the type:bug Something isn't working. label Aug 9, 2021
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me! 👍🏽

@jeffpaul jeffpaul merged commit 6f45188 into develop Aug 18, 2021
@jeffpaul jeffpaul deleted the fix/279 branch August 18, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scan Text option still available if Enable OCR is disabled
3 participants