Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Detect Text error message visibility #300

Merged
merged 2 commits into from
Aug 18, 2021
Merged

fix: Detect Text error message visibility #300

merged 2 commits into from
Aug 18, 2021

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Aug 9, 2021 •
edited
Loading

Resolves #298

Description of the Change

Added an additional check for error messages for the /ocr endpoint.

Verification Process

Clicked the 'Detect Text' button to verify if the error message is being shown.
Screenshot 2021-08-09 at 5 05 46 PM

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fix - issues with error messages not being displayed for 'Detect Text' feature.

@jeffpaul jeffpaul added this to the 1.7.0 milestone Aug 9, 2021
@jeffpaul jeffpaul added the type:bug Something isn't working. label Aug 9, 2021
dinhtungdu
dinhtungdu approved these changes Aug 15, 2021
View reviewed changes
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me! 👍🏽

@jeffpaul jeffpaul merged commit b0e70ed into develop Aug 18, 2021
@jeffpaul jeffpaul deleted the fix/298 branch August 18, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhtungdu dinhtungdu dinhtungdu approved these changes

Assignees

@Sidsector9 Sidsector9

Labels
type:bug Something isn't working.
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Detect Text on error doesn't show error message
3 participants
@Sidsector9 @dinhtungdu @jeffpaul