-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classifai/Providers/Watson/NLU.php updates #313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thrijith LGTM! Thanks for working on this. Can you please fix the failed workflows before merging this one?
@dinhtungdu it seems the failures were unrelated to the change but I've tried to fix it, please check again when you get a chance, the test failure for one was due to missing function which seems to have been removed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 . Great work @thrijith!
Description of the Change
can_register()
method forClassifai/Providers/Watson/NLU.php
.check_license_key
fromClassifai/Providers/Watson/NLU.php
.Alternate Designs
N/A
Benefits
Possible Drawbacks
N/A
Verification Process
Checklist:
Applicable Issues
#260
Changelog Entry
Implement
can_register
for NLU.Remove unused
check_license_key
method.