Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create codeql-analysis.yml #314

Merged
merged 1 commit into from
Nov 13, 2021
Merged

Create codeql-analysis.yml #314

merged 1 commit into from
Nov 13, 2021

Conversation

jeffpaul
Copy link
Member

Description of the Change

This adds the GitHub CodeQL Analysis code scanning alert action.

Alternate Designs

n/a

Benefits

Currently only scanning our JS code, but helpful to ensure that code is as secure as we can manage with automated tooling.

Possible Drawbacks

None identified

Verification Process

We'll have to run this and see!

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

n/a

Changelog Entry

Add - CodeQL Analaysis code scanning action.

@jeffpaul jeffpaul added this to the 1.8.0 milestone Nov 10, 2021
@jeffpaul jeffpaul requested a review from helen November 10, 2021 19:47
@jeffpaul jeffpaul self-assigned this Nov 10, 2021
helen
helen approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@helen helen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not toooo much JS going on in here but sounds good to me :)

@vikrampm1 vikrampm1 added the type:enhancement New feature or request. label Nov 11, 2021
@jeffpaul jeffpaul merged commit cf2a656 into develop Nov 13, 2021
@jeffpaul jeffpaul deleted the add/code-scanning branch November 13, 2021 00:56
@jeffpaul jeffpaul modified the milestones: 1.8.0, 1.7.1 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helen helen helen approved these changes

Assignees

@jeffpaul jeffpaul

Labels
type:enhancement New feature or request.
Projects
Open Source Practice
Archived in project
Milestone
1.7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffpaul @helen @vikrampm1