Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phpunit issue: Missing PHPUnit Polyfills library. #319

Merged
merged 3 commits into from
Dec 10, 2021
Merged

Conversation

rahulsprajapati
Copy link
Contributor

@rahulsprajapati rahulsprajapati commented Dec 9, 2021

Description of the Change

Add composer require --dev yoast/phpunit-polyfills:^1.0.0 package for phpunit polyfills.

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes: #318

Changelog Entry

  • Add yoast/phpunit-polyfills:^1.0.0 dev package for phpunit polyfills.

@rahulsprajapati rahulsprajapati marked this pull request as draft December 9, 2021 10:14
@rahulsprajapati rahulsprajapati self-assigned this Dec 9, 2021
Error:
- psr/container 1.x-dev requires php >=7.4.0 -> your PHP version (7.2.34) does not satisfy that requirement.
@rahulsprajapati rahulsprajapati marked this pull request as ready for review December 9, 2021 10:33
@jeffpaul jeffpaul added this to the 1.8.0 milestone Dec 9, 2021
@jeffpaul jeffpaul requested review from a team and iamdharmesh and removed request for a team December 9, 2021 14:44
@jeffpaul jeffpaul merged commit 68a297b into develop Dec 10, 2021
@jeffpaul jeffpaul deleted the fix/phpunit branch December 10, 2021 15:10
@jeffpaul jeffpaul modified the milestones: 1.8.0, 1.7.1 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHPUnit Fails: Missing PHPUnit Polyfills.
3 participants