Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated copy around Image Processing functions #325

Merged
merged 8 commits into from
Feb 22, 2022
Merged

Updated copy around Image Processing functions #325

merged 8 commits into from
Feb 22, 2022

Conversation

s3rgiosan
Copy link
Member

@s3rgiosan s3rgiosan commented Feb 14, 2022 •
edited
Loading

Description of the Change

Normalize copy around Image Processing functions.

Closes #280

Alternate Designs

N/A

Possible Drawbacks

None identified.

Verification Process

See Google Doc with updated copy recommendations.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

### Changed
- Normalize copy around Image Processing functions (props @s3rgiosan)

@jeffpaul jeffpaul added this to the 1.8.0 milestone Feb 15, 2022
@s3rgiosan s3rgiosan marked this pull request as ready for review February 16, 2022 16:00
@jeffpaul jeffpaul requested review from a team and iamdharmesh and removed request for jeffpaul and a team February 17, 2022 14:25
iamdharmesh
iamdharmesh approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work here @s3rgiosan.
LGTM!! 👍

@jeffpaul jeffpaul merged commit 9754104 into develop Feb 22, 2022
@jeffpaul jeffpaul deleted the fix/280 branch February 22, 2022 22:50
@jeffpaul jeffpaul modified the milestones: 1.8.0, 1.7.1 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffpaul jeffpaul jeffpaul left review comments

@iamdharmesh iamdharmesh iamdharmesh approved these changes

Assignees

@s3rgiosan s3rgiosan

Labels
None yet
Projects
None yet
Milestone
1.7.1
Development

Successfully merging this pull request may close these issues.

Normalize copy around Image Processing functions
3 participants
@s3rgiosan @jeffpaul @iamdharmesh