Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter to modify the registration conditions for the SavePostHandler class. #341

Merged
merged 7 commits into from
May 20, 2022
Merged

Add filter to modify the registration conditions for the SavePostHandler class. #341

merged 7 commits into from
May 20, 2022

Conversation

s3rgiosan
Copy link
Member

@s3rgiosan s3rgiosan commented May 3, 2022 •
edited
Loading

Description of the Change

This PR introduces a filter to modify the registration conditions for the SavePostHandler class.

Closes #123

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Added - classifai_should_register_save_post_handler filter; allows modifying the registration conditions for the SavePostHandler class (props @s3rgiosan via #341).

Credits

Props @s3rgiosan

@s3rgiosan s3rgiosan mentioned this pull request May 3, 2022
Closed
@s3rgiosan s3rgiosan requested review from dkotter and jeffpaul May 3, 2022 22:22
@s3rgiosan s3rgiosan marked this pull request as ready for review May 3, 2022 22:22
@s3rgiosan s3rgiosan changed the title Simplify logic behind can_register function for the SavePostHandler Add filter to modify the registration conditions for the SavePostHandler class. May 3, 2022
@jeffpaul jeffpaul requested review from a team and removed request for jeffpaul May 4, 2022 00:52
@jeffpaul jeffpaul added this to the 1.8.0 milestone May 4, 2022
@jeffpaul jeffpaul requested a review from dkotter May 16, 2022 20:37
@dkotter dkotter merged commit 994fd33 into develop May 20, 2022
@dkotter dkotter deleted the fix/123 branch May 20, 2022 16:04
@jeffpaul jeffpaul modified the milestones: 1.8.0, 1.7.2 Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

Assignees

@s3rgiosan s3rgiosan

Labels
None yet
Projects
None yet
Milestone
1.7.2
Development

Successfully merging this pull request may close these issues.

RSS Feed ingestion not triggering Watson NLU tagging
3 participants
@s3rgiosan @dkotter @jeffpaul