Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/315: add support for relative URLs #350

Merged
merged 2 commits into from
Jul 5, 2022
Merged

fix/315: add support for relative URLs #350

merged 2 commits into from
Jul 5, 2022

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Jun 28, 2022 •
edited
Loading

Description of the Change

Fixes issue reported by MS Computer Vision when the image URL is relative.

Closes #315

Verification Process

  1. Once you've connected to MS Computer Vision, set the following constant in the wp-config.php file to simulate the situation of the issue reporter.
define( 'WP_CONTENT_URL', '/wp-content' );
  1. Upload an image and confirm that the file URL shown is relative.
  2. Generate Alt-tags by clicking the Rescan button
  3. Observe the image

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fixed - bad URL error for relative URLs

Credits

Props @Sidsector9
Special props to @iamdharmesh for helping me out with the setup 🤓

@Sidsector9 Sidsector9 self-assigned this Jun 28, 2022
@Sidsector9 Sidsector9 requested review from a team, qasumitbagthariya and dinhtungdu and removed request for a team and qasumitbagthariya June 28, 2022 14:35
@jeffpaul jeffpaul added this to the 1.8.0 milestone Jun 28, 2022
dinhtungdu
dinhtungdu previously approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a small typo issue but the PR looks good! Thanks for working on this! :shipit:

includes/Classifai/Providers/Azure/ComputerVision.php Outdated Show resolved Hide resolved
@Sidsector9 Sidsector9 requested review from dinhtungdu and removed request for dinhtungdu July 5, 2022 06:22
@jeffpaul jeffpaul merged commit 62763b1 into develop Jul 5, 2022
@jeffpaul jeffpaul deleted the fix/315 branch July 5, 2022 17:46
@dkotter dkotter modified the milestones: 1.8.0, 1.7.3 Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhtungdu dinhtungdu dinhtungdu approved these changes

Assignees

@Sidsector9 Sidsector9

Labels
None yet
Projects
None yet
Milestone
1.7.3
Development

Successfully merging this pull request may close these issues.

Add support for relative path images
4 participants
@Sidsector9 @dinhtungdu @dkotter @jeffpaul