-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/193: add a previewer in admin settings #351
Conversation
@jeffpaul What title should we add to the previewer? Also wanted your opinion on the results, is there anything we would want to add/remove in this implementation? |
How about
It might help to show placeholders for the Categories, Keywords, Entities, and Concepts sections where data eventually gets returned/rendered so that section doesn't suddenly jump down when the data's ready? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the great work here @Sidsector9. Overall code looks good to me, just added a few minor comments to check.
Also, please help to add title as mentioned here #351 (comment)
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 Thanks for great work here @Sidsector9
Description of the Change
This PR adds a feature to display preview of the taxonomy types for a post.
Closes #193
Screencast
Classifai.mov
Checklist:
Changelog Entry
Credits
Props @Sidsector9