Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/193: add a previewer in admin settings #351

Merged
merged 8 commits into from
Jul 20, 2022
Merged

feat/193: add a previewer in admin settings #351

merged 8 commits into from
Jul 20, 2022

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Jul 3, 2022

Description of the Change

This PR adds a feature to display preview of the taxonomy types for a post.

  1. Adds a select dropdown with AJAX-based search input field to select/search a post.
  2. Displays the score/relevance and the label in results.
  3. Displays color-based bar with a width indicating score for visual clarity.

Closes #193

Screencast

Classifai.mov

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Added - Preview for Language Processing settings changes

Credits

Props @Sidsector9

@Sidsector9 Sidsector9 self-assigned this Jul 3, 2022
@Sidsector9
Copy link
Member Author

@jeffpaul What title should we add to the previewer? Also wanted your opinion on the results, is there anything we would want to add/remove in this implementation?

@Sidsector9 Sidsector9 requested review from a team and jayedul and removed request for a team July 3, 2022 19:19
@jeffpaul
Copy link
Member

jeffpaul commented Jul 6, 2022

What title should we add to the previewer?

How about Preview Language Processing?

Also wanted your opinion on the results, is there anything we would want to add/remove in this implementation?

It might help to show placeholders for the Categories, Keywords, Entities, and Concepts sections where data eventually gets returned/rendered so that section doesn't suddenly jump down when the data's ready?

@jeffpaul jeffpaul requested review from a team and iamdharmesh and removed request for jayedul and a team July 7, 2022 18:10
@jeffpaul jeffpaul added this to the 1.8.0 milestone Jul 7, 2022
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the great work here @Sidsector9. Overall code looks good to me, just added a few minor comments to check.
Also, please help to add title as mentioned here #351 (comment)

Thanks

includes/Classifai/Admin/PreviewClassifierData.php Outdated Show resolved Hide resolved
includes/Classifai/Admin/PreviewClassifierData.php Outdated Show resolved Hide resolved
src/js/admin.js Outdated Show resolved Hide resolved
@Sidsector9
Copy link
Member Author

Empty placeholders added:

Screenshot 2022-07-18 at 12 25 47 AM

With results populated:

Screenshot 2022-07-18 at 12 38 14 AM

Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Thanks for great work here @Sidsector9

@jeffpaul jeffpaul merged commit ce4697b into develop Jul 20, 2022
@jeffpaul jeffpaul deleted the feat/193 branch July 20, 2022 20:47
@dkotter dkotter modified the milestones: 1.8.0, 1.7.3 Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add live preview of results for threshold settings
4 participants