Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Generate/Regenerate/Scan buttons for newly uploaded media. #364

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

iamdharmesh
Copy link
Member

Description of the Change

As described in #304, generate/regenerate/rescan buttons are not working for newly uploaded images, This PR contains changes to make it work.

Closes #304

How to test the Change

  1. Create a new post.
  2. Add Image block and click "Media Library"
  3. Switch to the "Upload files" tab in the media library.
  4. Upload the image and wait for success and buttons in the attachment details sidebar.
  5. Click on any Generate/Regenerate/Scan button and make sure it works fine.

Changelog Entry

Fixed - Generate/Regenerate/Scan buttons for newly uploaded media.

Credits

Props @iamdharmesh @jeffpaul @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh self-assigned this Sep 5, 2022
@iamdharmesh iamdharmesh requested review from a team and cadic and removed request for a team September 5, 2022 09:42
@iamdharmesh iamdharmesh added this to the 1.8.0 milestone Sep 5, 2022
@jeffpaul jeffpaul merged commit 99cbec9 into develop Sep 13, 2022
@jeffpaul jeffpaul deleted the enhancement/304 branch September 13, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media modal improvement for new uploads
3 participants