Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yahnis-elsts/plugin-update-checker from 4.6 to 4.13 #365

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Sep 8, 2022

Description of the Change

The Plugin Update Checker library we use is also used on a few other 10up projects. Some of those are running different versions though, leading to conflicts (especially when using composer to manage all dependencies of a project). This PR updates this library to the latest version, which will also be done in other repos that are using this library.

Alternatively we could use something like mozart or PHP-Scoper to add a distinct namespace to this dependency. I'm not opposed to this necessarily but because we're seeing conflicts with other plugins that we fully control, I like the idea of just ensuring all of those projects are using the same version.

How to test the Change

  1. Pull these changes down
  2. Within the classifai.php file, set the version number to something lower, like 1.6.0
  3. Ensure you have a proper license in place
  4. Go to the plugins section and ensure you see an update notice for Classifai (may need to click the Check for updates link; also ensure the plugin is active)
  5. Click on the View version X.X.X details link and ensure you see proper details
  6. Go to the WordPress Updates page and ensure you see Classifai there as well, with the icon
  7. Click on the View version X.X.X details link and ensure you see proper details
  8. If desired, click the update now link and ensure an update works (either from the plugins page or the main updates page). Note though that this will wipe out your version controlled classifai directory, so proceed with caution

Changelog Entry

Changed - Upgrade the Plugin Update Checker library to 4.13

Credits

Props @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter self-assigned this Sep 8, 2022
@dkotter dkotter marked this pull request as ready for review September 9, 2022 15:31
@jeffpaul jeffpaul added this to the 1.8.0 milestone Sep 9, 2022
@dkotter dkotter requested review from a team and Sidsector9 and removed request for a team September 9, 2022 15:50
@iamdharmesh iamdharmesh mentioned this pull request Sep 16, 2022
17 tasks
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2022-09-22 at 5 42 35 PM

Screenshot 2022-09-22 at 5 42 52 PM

Screenshot 2022-09-22 at 5 43 06 PM

Screenshot 2022-09-22 at 5 44 08 PM

LGTM ✅

@dkotter dkotter merged commit 58fcdff into develop Sep 22, 2022
@dkotter dkotter deleted the feature/update-plugin-updater branch September 22, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants