Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress integration migrated to 11+ #385

Merged
merged 3 commits into from
Jan 26, 2023
Merged

Cypress integration migrated to 11+ #385

merged 3 commits into from
Jan 26, 2023

Conversation

jayedul
Copy link
Contributor

@jayedul jayedul commented Dec 12, 2022

Description of the Change

Cypress integration migrated to 11+

Closes #382

How to test the Change

  • Install NPM dependencies
  • Run npm run cypress:run to test without GUI
  • Run npm run cypress:open to test with GUI
  • Check if tests pass successfully

Changelog Entry

Changed - Cypress integration migrated to 11+

Credits

Props @jayedul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jayedul jayedul self-assigned this Dec 12, 2022
@jayedul
Copy link
Contributor Author

jayedul commented Dec 12, 2022

All tests except Linting passed successfully after Cypress migration. As it is not part of this pull request, I did nothing on it in this ticket.

@jayedul jayedul requested a review from dkotter December 12, 2022 15:16
@jayedul jayedul marked this pull request as ready for review January 20, 2023 17:52
@jayedul jayedul requested review from a team and jeffpaul as code owners January 20, 2023 17:52
Copy link

@cadic cadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the upgrade @jayedul!

@Sidsector9 Sidsector9 merged commit ea78cf4 into develop Jan 26, 2023
@Sidsector9 Sidsector9 deleted the fix/382 branch January 26, 2023 06:41
@jeffpaul jeffpaul added this to the 1.9.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Cypress 11
4 participants