Added "Build release zip" Workflow. #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdharmesh
requested review from
a team and
peterwilsoncc
and removed request for
a team
peterwilsoncc
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
LGTM based on a review of the zip attached to https://github.com/iamdharmesh/classifai/actions/runs/3837994649
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
PR adds a "Build release zip" workflow to upload built ZIP file on GH release, workflow also can be manually triggered to generate a zip for a specific branch of the repo.
Closes #367
How to test the Change
Upload zip to release: We can test during the release process. Not sure how we can test before that.
Generate zip manually: We can test this after merging this PR.
Changelog Entry
Credits
Props @iamdharmesh @jeffpaul
Checklist: