Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing E2E tests #406

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Fix failing E2E tests #406

merged 1 commit into from
Mar 10, 2023

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Mar 10, 2023

Description of the Change

Update to the latest version of our Cypress WP Util library to fix failing E2E tests. Also bumps our minimum WordPress version we test on to 5.7 since that's the minimum version we support and updates a few GitHub Actions used in our E2E testing.

Note
Our eslint test is failing; looks like some existing JS issues that need fixed up. I'll tackle that in a separate PR.

How to test the Change

Ensure the E2E checks are passing on this PR.

Changelog Entry

Not sure this even needs to go in our changelog

Fixed - Ensure our E2E tests pass

Credits

Props @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

…f WordPress version we test on to match our min. Update a few actions
@dkotter dkotter self-assigned this Mar 10, 2023
@dkotter dkotter marked this pull request as ready for review March 10, 2023 19:44
@dkotter dkotter requested review from jeffpaul and a team as code owners March 10, 2023 19:44
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing!

@jeffpaul jeffpaul added this to the 1.9.0 milestone Mar 10, 2023
@jeffpaul jeffpaul merged commit f6e02da into develop Mar 10, 2023
@jeffpaul jeffpaul deleted the fix/e2e-tests branch March 10, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants