Fix failing eslint tests #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew other things in the Action, like updating various Actions and adding in caching
jeffpaul
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Updates our linting action to run
npm run lint:js, which in turn runswp-scripts lint-js. This ensures we have more accurate linting done in this action.Also cleaned up a few things in the eslint action like:
Finally this PR cleans up all existing eslint errors.
How to test the Change
Verify the eslint action is passing on this PR.
Changelog Entry
Not sure this even needs to go in our changelog
Credits
Props @dkotter
Checklist: