Do not cache node_modules/ #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkotter
reviewed
Mar 13, 2023
| - name: Setup node v16 and npm cache | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16 | ||
| cache: 'npm' | ||
| cache: npm |
There was a problem hiding this comment.
Looking at the documentation for actions/setup-node they say to have quotes around this value: https://github.com/actions/setup-node#caching-global-packages-data. Not sure if it matters or not but feels like you should follow their guidance
There was a problem hiding this comment.
Actually all YAML strings should be quoted: https://github.com/szepeviktor/debian-server-tools/blob/master/webserver/Continuous-integration-Continuous-delivery.yml
I've removed those quotes to be in harmony with other parts of the workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is already handled by
actions/setup-node.Never cache
node_modules/. It results in an unpredictable state.It takes 1-2 seconds to copy files from npm cache to
node_modules/.