Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassifAI NUX #411

Merged
merged 54 commits into from
Apr 28, 2023
Merged

ClassifAI NUX #411

merged 54 commits into from
Apr 28, 2023

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Mar 15, 2023

Description of the Change

PR Adds new user onboarding and updates existing settings UI.

Closes #30

Screenshots:

Activation Notice:
image

ClassifAI Step 1:
screencapture-classifai-local-wp-admin-admin-php-2023-04-28-20_06_33

ClassifAI Step 2:
Screenshot 2023-03-31 at 11 16 01 AM

ClassifAI Step 3:
Screenshot 2023-03-31 at 11 14 31 AM

Setup Summary:
Screenshot 2023-04-28 at 8 04 12 PM

Classifai Settings:
Screenshot 2023-03-31 at 11 18 55 AM
Screenshot 2023-03-31 at 11 19 05 AM

Reviewer Notes:

  • Placeholder images are added in step 1 and the summary step. it will be replaced with actual images once we have images available. I have made PR ready for review to unblock the process here. (@jeffpaul could please help to get images for the same)
  • E2E tests are not added as part of this PR, I will add it in the follow-up PR.

How to test the Change

  1. Install and activate the plugin.
  2. Verify that the notice for start setup is there.
  3. Start ClassifAI set up by clicking the button in the activation notice.
  4. Go through each step of setup and make sure everything works fine
  5. Go to ClassifAI settings and check the new UI and make sure everything works fine.

Changelog Entry

Added - Classifai Setup onboarding and UI improvements.

Credits

Props @ryanwelcher @jeffpaul @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 1.9.0 milestone Mar 15, 2023
dkotter
dkotter previously approved these changes Apr 5, 2023
@dkotter
Copy link
Collaborator

dkotter commented Apr 5, 2023

Code here is looking good. I've not done an in-depth round of testing yet though.

Copy link

@mehidi258 mehidi258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great to me, Though i have added few very nitpicky improvements from FE perspective which are great to have.

includes/Classifai/Admin/Notifications.php Outdated Show resolved Hide resolved
includes/Classifai/Admin/templates/classifai-header.php Outdated Show resolved Hide resolved
includes/Classifai/Admin/templates/classifai-header.php Outdated Show resolved Hide resolved
includes/Classifai/Admin/templates/classifai-header.php Outdated Show resolved Hide resolved
includes/Classifai/Admin/templates/classifai-header.php Outdated Show resolved Hide resolved
@iamdharmesh
Copy link
Member Author

Thanks for the review @mehidi258. I have updated the code accordingly. Could you please help to review it once?

mehidi258
mehidi258 previously approved these changes Apr 6, 2023
@mehidi258
Copy link

Thanks for the review @mehidi258. I have updated the code accordingly. Could you please help to review it once?

@iamdharmesh Thanks for resolving those, Looks great to me. Though regarding adding escaping functions @dkotter mentioned that those escaping are not needed. Sorry for flagging those, feel free to revert those escpaing changes

@iamdharmesh
Copy link
Member Author

Hi @jeffpaul @dkotter, I have updated PR for the points we discussed during the demo. Could you please help to review it once? Also, Please let me know if any wording updates are needed anywhere.

Header:

  • Keep the "Set up" link always there. (even after setup is complete)

Step - 1 (Enable features):

  • Default Enabled features:
    For new users: ALL features are enabled by default except any CPTs for Language Processing
    For existing users: Only completely configured features should be enabled by default

Step - 2 (Registration):

  • Skip it if it is already configured

Step - 4 (summary page):

  • Add not configured features as well with (x) icon before the feature name

Plugins list page:

  • Add setup and settings link in the plugins list page

General:

  • Move the ClassifAI menu under the tools menu and remove the top-level menu
  • Page title for “ClassifAI Setup” page
  • Disable WordPress "Plugin Activated" notice.

Thanks

dkotter
dkotter previously approved these changes Apr 20, 2023
classifai.php Show resolved Hide resolved
@dkotter dkotter merged commit ae7f106 into develop Apr 28, 2023
@dkotter dkotter deleted the enhancement/30 branch April 28, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassifAI New User Experience and updated setting pages
6 participants