-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClassifAI NUX #411
ClassifAI NUX #411
Conversation
Code here is looking good. I've not done an in-depth round of testing yet though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great to me, Though i have added few very nitpicky improvements from FE perspective which are great to have.
Thanks for the review @mehidi258. I have updated the code accordingly. Could you please help to review it once? |
@iamdharmesh Thanks for resolving those, Looks great to me. Though regarding adding escaping functions @dkotter mentioned that those escaping are not needed. Sorry for flagging those, feel free to revert those escpaing changes |
Hi @jeffpaul @dkotter, I have updated PR for the points we discussed during the demo. Could you please help to review it once? Also, Please let me know if any wording updates are needed anywhere. Header:
Step - 1 (Enable features):
Step - 2 (Registration):
Step - 4 (summary page):
Plugins list page:
General:
Thanks |
Description of the Change
PR Adds new user onboarding and updates existing settings UI.
Closes #30
Screenshots:
Activation Notice:
ClassifAI Step 1:
ClassifAI Step 2:
ClassifAI Step 3:
Setup Summary:
Classifai Settings:
Reviewer Notes:
How to test the Change
Changelog Entry
Credits
Props @ryanwelcher @jeffpaul @iamdharmesh
Checklist: