Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get_plugin_settings usage to name provider #418

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Update get_plugin_settings usage to name provider #418

merged 1 commit into from
Mar 22, 2023

Conversation

Spoygg
Copy link

@Spoygg Spoygg commented Mar 22, 2023 •
edited by dkotter
Loading

Description of the Change

Updated usage of get_plugin_settings as described in #413

Closes #413

Changelog Entry

Changed - update usage of get_plugin_settings to new function signature

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@Spoygg Spoygg self-assigned this Mar 22, 2023
@Spoygg Spoygg requested review from a team, dkotter and jeffpaul as code owners March 22, 2023 17:41
@Spoygg Spoygg mentioned this pull request Mar 22, 2023
Closed
1 task
@jeffpaul jeffpaul added this to the 1.9.0 milestone Mar 22, 2023
@jeffpaul jeffpaul requested review from a team and removed request for a team and jeffpaul March 22, 2023 20:23
@dkotter dkotter merged commit 260bb6e into develop Mar 22, 2023
@dkotter dkotter deleted the feature/update-usage-of-get_plugin_settings branch March 22, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

Assignees

@Spoygg Spoygg

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Update all usages of get_plugin_settings
4 participants
@Spoygg @dkotter @jeffpaul @ivanicsf