Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/429 add attributation and assign post to image generation #438

Merged
merged 6 commits into from
Apr 11, 2023

Conversation

derweili
Copy link
Member

@derweili derweili commented Apr 10, 2023

Description of the Change

  • Add "Image generated by OpenAI's DALL·E" attributation as image caption when importing generated images.
  • Add new classifai_dalle_caption filter to modify this caption via PHP.
  • Assign the current post to the imported attachment.

Closes #429

How to test the Change

  1. Edit a post and generate a image using Dall-E
  2. Import the image
  3. Go to the media library
  4. Verify the newly imported image is attached to the post you just edited.
  5. Verify the newly imported image has the "Image generated by OpenAI's DALL·E" attributation as a caption.

Changelog Entry

Added - DALL-E default attributation as image caption.
Added - Assign generated image to post.

Credits

Props @derweili

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

- Add caption to `classifaiDalleData` variable.
- Pass caption to `uploadMedia` function.
@derweili derweili requested review from a team, dkotter and jeffpaul as code owners April 10, 2023 19:25
@derweili derweili assigned derweili and dkotter and unassigned derweili Apr 10, 2023
@derweili derweili added the needs:code-review This requires code review. label Apr 10, 2023
@jeffpaul jeffpaul added this to the 2.1.0 milestone Apr 10, 2023
@dkotter dkotter merged commit 5c1be7a into develop Apr 11, 2023
@dkotter dkotter deleted the feature/429-add-attributation-to-image-generation branch April 11, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default attribution to generated images
3 participants