Ensure we don't send unnecessary API requests to NLU #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to be a wrapper for the new is_configured method. For all existing providers that had the same can_register check, remove that method from the child class so they will rely on the parent method
…n other providers. Update the can_register method of NLU to match more closely to other providers as well
4 tasks
iamdharmesh
previously approved these changes
May 18, 2023
There was a problem hiding this comment.
Thanks for working on this and saving lots of requests @dkotter. LGTM. 🚀
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
As detailed in #415, there's a request on each page load (admin or front-end) to the NLU API to check to see if authentication is valid. These requests are unnecessary, leading to potential performance issues but more importantly, extra API usage.
This PR fixes that by refactoring the
can_registermethod that all Providers use. For all other Providers besides NLU, we've removed thecan_registermethod and instead rely on the parentcan_registermethod.For NLU, the
can_registermethod now calls theis_configuredmethod, which calls the parentis_configuredmethod (matching what other providers do) but also checks the existingclassifai_configuredoption to retain backwards compatibility. These changes fix the extra API requests, remove duplicate code and helps make things a little more consistent between Providers.Closes #415
How to test the Change
Ensure all Providers still work if configured properly and don't work if not configured properly
Changelog Entry
Credits
Props @dkotter, @benlk
Checklist: