Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve ESlint issues #461

Merged
merged 4 commits into from
May 23, 2023
Merged

Resolve ESlint issues #461

merged 4 commits into from
May 23, 2023

Conversation

ravinderk
Copy link
Contributor

@ravinderk ravinderk commented May 23, 2023

Description of the Change

This pull request resolves eslint formatting issues in the javascript file.

Closes #450

How to test the Change

The ESlint command should process without error.
npm run lint:js

Changelog Entry

Dev: resolve formatting issues in javascript files

Credits

Props @dkotter @ravinderk

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@ravinderk ravinderk self-assigned this May 23, 2023
@ravinderk ravinderk added this to the 2.3.0 milestone May 23, 2023
@ravinderk ravinderk marked this pull request as ready for review May 23, 2023 06:00
@ravinderk ravinderk requested review from a team, dkotter and jeffpaul as code owners May 23, 2023 06:00
@dkotter dkotter merged commit d9ab444 into develop May 23, 2023
@dkotter dkotter deleted the chore/eslint-formatting-issue-450 branch May 23, 2023 18:44
@dkotter dkotter modified the milestones: 2.3.0, 2.2.1 May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint failures on existing JS files
2 participants