-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly add terms to posts generated by Watson content classifiers #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravinderk
changed the title
Correctly add Term Tags to page/posts
Correctly add terms to posts generated by Watson content classifiers
May 23, 2023
dkotter
requested changes
May 24, 2023
@dkotter Pull request is ready for code review. |
dkotter
requested changes
May 25, 2023
dkotter
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
I found that we overwrite terms when adding new terms to a post. Admin can set same or different WordPress taxonomy for Watson
Category
,Keyword
,Entity
&Concept
. When the admin sets the same category for two or more Watson content classifiers, the term does not add correctly to the post. I update the logic to handle this use case.Closes #340
How to test the Change
ClassifAI
>Language Processing
and the new post. The post should have the correct terms.ClassifAI
>Language Processing
and the new post. The post should have the correct terms.Changelog Entry
Credits
Props @iamdharmesh , @ravinderk
Checklist: