Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image generation support to the classic editor #471

Merged
merged 4 commits into from
Jun 6, 2023
Merged

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented May 26, 2023

Description of the Change

When we added the image generation feature, we didn't add support for that in the Classic Editor. In looking into this, it was pretty easy to add this for the Featured Image section and after some testing, I was able to get it working for in-content media as well.

The Featured Image experience is basically the exact same as what we have in the Block Editor. For in-content images, the modal itself is slightly different (it has a left-hand sidebar) and the process of selecting and inserting an image slightly differs as well, but generating and inserting does work, so I think this is an okay compromise.

Closes #465

How to test the Change

  1. Install the Classic Editor plugin
  2. Create a new classic post
  3. Click to add a featured image and notice the Generate images tab shows up
  4. Ensure generating images work and inserting one of those images as a featured image works as well
  5. Click on the Add Media button above the editor
  6. Ensure the Generate images tab shows in this modal
  7. Ensuring generating and inserting images works from here

Changelog Entry

Added - Ability to generate images in the Classic Editor

Credits

Props @dkotter, @mattbbs

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter added this to the 2.2.1 milestone May 26, 2023
@dkotter dkotter requested a review from a team as a code owner May 26, 2023 21:47
@dkotter dkotter self-assigned this May 26, 2023
@dkotter dkotter requested a review from jeffpaul as a code owner May 26, 2023 21:47
@dkotter dkotter marked this pull request as draft May 26, 2023 22:22
@dkotter dkotter changed the title Add image generation support to the featured image section in the classic editor WIP: Add image generation support to the classic editor May 26, 2023
@dkotter dkotter changed the title WIP: Add image generation support to the classic editor Add image generation support to the classic editor Jun 2, 2023
@dkotter dkotter marked this pull request as ready for review June 2, 2023 15:49
@jeffpaul jeffpaul requested review from a team and removed request for a team June 2, 2023 17:05
@dkotter dkotter merged commit a8f0f2d into develop Jun 6, 2023
@dkotter dkotter deleted the feature/465 branch June 6, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Generation doesn't work with Classic Editor pluign
2 participants