Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump various dependencies #476

Merged
merged 11 commits into from
Jun 8, 2023
Merged

Bump various dependencies #476

merged 11 commits into from
Jun 8, 2023

Conversation

jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented Jun 2, 2023

Description of the Change

This PR will be a slow process of iterative dependency updates to see what all can be bumped across the stack and still have actions/tests pass.

How to test the Change

Load PR locally and test ClassifAI activation, setup flows, language processing, image processing, and recommended content tasks still function as expected.

Changelog Entry

Security - Bumped various dependencies.

Note we can be more specific on the above once we determine when the various iterative commits here are stable enough to merge and then see what dependencies ultimately were updated.

Credits

Props @jeffpaul.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 2.2.1 milestone Jun 2, 2023
@jeffpaul jeffpaul self-assigned this Jun 2, 2023
@jeffpaul
Copy link
Member Author

jeffpaul commented Jun 2, 2023

Ok I think that's about as far as I'll likely be able to get things updated... all further updates I've explored have conflicting required dependencies that are not currently able to be resolved.

@jeffpaul jeffpaul marked this pull request as ready for review June 2, 2023 15:55
@jeffpaul jeffpaul requested review from a team and dkotter as code owners June 2, 2023 15:55
ravinderk
ravinderk previously approved these changes Jun 4, 2023
Copy link
Contributor

@ravinderk ravinderk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffpaul npm install and npm run build update command work as expected.

@dkotter dkotter requested a review from ravinderk June 7, 2023 19:47
@dkotter
Copy link
Collaborator

dkotter commented Jun 7, 2023

@ravinderk This is ready for another review.

I've gone through and gotten all dependencies updated besides one (at least as of this comment, I'm sure by the time you read this something will already be out of date).

The one remaining one is svg-react-loader. We currently use v0.4.0 and the latest is v0.4.6. There's no issue as far as I can see in updating but doing so does introduce some new security issues (though to be fair, the current version also has security issues). For now I've left this alone, though we may want to find an alternative as it seems it may be abandoned.

In updating husky, cypress and wp-env to their latest versions, I did have to fix a few things, so those are what needs to be reviewed the closest. All tests are currently passing but just want to ensure everything looks good to you.

@dkotter dkotter merged commit 4574e3c into develop Jun 8, 2023
@dkotter dkotter deleted the update/deps branch June 8, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants