-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#486 - Optimize calls to Microsoft Azure Text to Speech API #487
#486 - Optimize calls to Microsoft Azure Text to Speech API #487
Conversation
@dkotter just noticed that if the audio attachment is deleted accidentally from the media library, this update would make it such that no new audio would be generated unless we deleted the audio id meta from the post. Thinking of taking care of that as part of this PR. Thoughts? |
Looks like you took care of that here, is that correct? If so, I think this is good to go |
@dkotter yes that is correct. Let me know if there is anything further that I need to do on this. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshuaabenazer Do we skip an audio generation when "Generate audio for this post" is set to no
during bulk action or WP CLI command? If not, can we optimize this too?
I don't believe we do but I also think that is by design. If someone manually is triggering this via the bulk actions or via our WP-CLI command, I think that should bypass that option. That is just my opinion though, happy to discuss that but I'd suggest that should be handled in a separate issue. |
Description of the Change
Closes #486
How to test the Change
Changelog Entry
Credits
Props @joshuaabenazer
Checklist: