Ensure we save the modified title and use that when we insert a title #509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
As described in #508, any edits made to generated titles before they are inserted don't persist. The problem lies in how we save edited titles and which title we use when inserting. Basically we weren't saving the edited title to state and we were using the raw generated title when inserting.
This PR changes both to ensure any edits made persist to our state object and then we use the state object when a title is inserted.
Closes #508
How to test the Change
Changelog Entry
Credits
Props @dkotter
Checklist: