Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenAI Embeddings in the Classic Editor Support #515

Merged
merged 11 commits into from
Jul 6, 2023

Conversation

phpbits
Copy link
Contributor

@phpbits phpbits commented Jun 29, 2023

Description of the Change

This PR adds the ClassifAI metabox for the classic editor for OpenAI Embeddings support.

Screen Shot 2023-06-29 at 8 54 52 PM

Closes #496

How to test the Change

  • Set up an integration with OpenAI in Language Processing > OpenAI Embeddings
  • Ensure the Classify content option is turned on and at least one Post type that has the block editor disabled.
  • In whatever taxonomy you've selected, ensure you have one or more terms saved
  • Create a new piece of content and publish that content (or match whatever post status option you selected)
  • Ensure one or more terms gets auto-assigned

Credits

Props @phpbits

Checklist:

@phpbits phpbits requested review from a team, dkotter and jeffpaul as code owners June 29, 2023 13:01
@jeffpaul jeffpaul removed their request for review June 29, 2023 15:48
@jeffpaul jeffpaul added this to the 2.2.3 milestone Jun 29, 2023
@phpbits phpbits requested a review from jeffpaul June 29, 2023 16:51
@phpbits
Copy link
Contributor Author

phpbits commented Jun 30, 2023

@jeffpaul @dkotter This is now ready for code review and QA. Thanks!

includes/Classifai/Admin/Metabox.php Outdated Show resolved Hide resolved
includes/Classifai/Admin/Metabox.php Outdated Show resolved Hide resolved
includes/Classifai/Admin/Metabox.php Outdated Show resolved Hide resolved
@dkotter
Copy link
Collaborator

dkotter commented Jun 30, 2023

Would also be great to add a Cypress test here to ensure this metabox shows properly in the Classic Editor. See https://github.com/10up/classifai/pull/518/files#diff-c4172826b0f360a287099211a31d6a1b8bee386d8dc8b6b5059730bfa77d4b30R84 for an example of how to do this

@phpbits
Copy link
Contributor Author

phpbits commented Jul 5, 2023

Would also be great to add a Cypress test here to ensure this metabox shows properly in the Classic Editor. See https://github.com/10up/classifai/pull/518/files#diff-c4172826b0f360a287099211a31d6a1b8bee386d8dc8b6b5059730bfa77d4b30R84 for an example of how to do this

@dkotter I've added one but it seems to be failing. Would you mind checking it out? Thanks!

…up with double options if both features are turned on. Remove unneeded conditional and make a few minor adjustments to display
@dkotter dkotter merged commit d34e7de into develop Jul 6, 2023
@dkotter dkotter deleted the feature/open-embeddings-classic-editor branch July 6, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support OpenAI Embeddings in the Classic Editor
3 participants