Make sure media scripts are loaded before we load our custom image generation JS #522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
As reported in #520, on some screens we get a JS console error from our custom Media Modal code. This JS file is only loaded if we're on either
post.php
orpost-new.php
, which is good, but this does mean it loads on custom post creation/edit screens, which may not have any media handling (like the External Connection flow that Distributor uses).It seems like the easy fix is to use the
wp_enqueue_media
function before loading our custom Media Modal JS file. In testing this, it fixed the reported issue and didn't cause any regressions from what I could see either in the Block Editor or Classic Editor image generation processes.Closes #520
How to test the Change
npm install && npm run build
Changelog Entry
Credits
Props @dkotter, @ravinderk
Checklist: