-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/488: Ability to resize post content using OpenAI's ChatGPT #532
Conversation
@Sidsector9 I chatted with Jake on this today and agreed the best option would be to add a new block toolbar option using either https://github.com/10up/classifai/blob/develop/assets/img/icon.svg or https://github.com/10up/classifai/blob/develop/assets/img/menu-icon.svg for the toolbar icon and then nesting the expand/reduce options in a dropdown there. |
Also, let's remove Subscriber from one of the default enabled roles for this (and maybe Contributor as well?) so that we don't get normal site visitors using up a sites OpenAI budget without an admin explicitly enabling that. |
3022689
to
12c6411
Compare
Left a few suggestions but also saw a couple other things:
|
@dkotter this feature is not working well on WP 6.3 due to major changes in the Block editor. It works fine in WP 6.2. A trick to make this feature work in WP 6.3 is to enable Custom Fields under Preferences > Panels. The animation works on a single line content as well: Screen.Recording.2023-08-26.at.12.25.54.AM.movI couldn't find a way to fix this, I'm still investigating. |
@Sidsector9 since this isn't a functional issue with the loading animation, perhaps remove that for now and open that in a separate PR to continue iterating on and can land in a 2.3.x minor release. Also, I confirmed and the existing "Expand this text" and "Condense this text" copy is good for us to ship. |
@Sidsector9 @jeffpaul Reviewing this again today in hopes of getting this merged and ran into one thing. Right now our E2E test is failing on WordPress 5.7 (our minimum) because we're using the I can see two paths forward:
Not sure how hard the first will be. I'm totally on board to bump our minimums but open to thoughts there. |
@dkotter I've bumped minimum WordPress version from 5.7 to 5.8 |
Description of the Change
The feature adds the ability to "grow" and "shrink" the paragraph block content. (Watch video below for demo)
Limitations
What is next?
The next improvement can be resizing content when multiple, consecutive paragraph blocks are selected.
Closes #488
Screenshot
1. Resizing content settings:
2. Grow content
Grow.24fps.mov
3. Shrink content
Shrink.24fps.mov
How to test the Change
/wp-admin/tools.php?page=classifai&tab=language_processing&provider=openai_chatgpt
Changelog Entry
Credits
Props @jeffpaul, @Sidsector9, @dkotter
Checklist: