-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial integration into the new Command Palette #536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @dkotter, Code looks good and it tests well. However, I noticed 1 warning about missing dependencies. otherwise all good to proceed with merging this.
Note: My OpenAI key is expired so, not tested title generation etc.. but the command properly triggers the operation for generating titles and excerpt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkotter, do you think we can make our command titles unique? It will be difficult for the admin to differentiate between two commands if they have the same title.
Are you thinking of just adding |
@dkotter I was thinking the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of the Change
Gutenberg v15.6.0 shipped with a new Command Palette that can be triggered within the site editor (by using the keyboard shortcut command+k). This feature should be shipping with WP 6.3. This PR does some initial integrations into this Command Palette but there are certainly more things we could add here (or in follow-up PRs).
At the moment, there are 4 commands we add here:
Command.Center.mov
How to test the Change
npm install && npm run build
ClassifAI: Generate excerpt
,ClassifAI: Generate title
,ClassifAI: Generate image
, orClassifAI settings
Changelog Entry
Credits
Props @dkotter
Checklist: