Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: enable comma delimited list of post ids to classifai #55

Merged
merged 6 commits into from
Sep 24, 2019

Conversation

adamsilverstein
Copy link

@adamsilverstein adamsilverstein commented Apr 10, 2019

Description of the Change

Explode the comma delimited list of post ids passed to the command.
Adjust the command docs to make it clear what should be passed.

Verification Process

type a comma delimited list of posts to classifai, eg:

wp classifai post 3602,3604,3606

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

@jeffpaul
Copy link
Member

@adamsilverstein is there a parallel update to the readme that should explicitly note how this works / provide an example?

@adamsilverstein
Copy link
Author

@jeffpaul the PR updates the docs you get when typing the CLI command, not sure if this is documented elsewhere, I'll look

@jeffpaul jeffpaul modified the milestones: 1.3.0, Future Release May 30, 2019
@jeffpaul
Copy link
Member

@adamsilverstein can you please update the readme as well to denote the update to the command?

@jeffpaul jeffpaul modified the milestones: Future Release, 1.4.0 Aug 23, 2019
@adamsilverstein
Copy link
Author

Added docs to the readme (as well as some editor induced whitespace cleanup) - see https://github.com/10up/classifai/pull/55/files?w=1 for the ignore whitespace changes view.

@helen helen merged commit 1f7bc76 into develop Sep 24, 2019
@jeffpaul jeffpaul deleted the fix/cli-comma-delimeted-ids branch March 5, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants