Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated release GH action workflow files. #565

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

iamdharmesh
Copy link
Member

Description of the Change

As discussed in #412, currently, the release zip archive not getting attached to the GH release. Earlier Generate release zip workflow was common between the release event and workflow dispatch event, but somehow workflow was not getting triggered on the release event. (Note: in b8d8d2c we updated the file to follow what we are doing in the distributor, but it creates zip without build files)

This PR updates release workflow files to fix the issue and also adds workflow dispatch generate zip workflow to manually generate a zip archive.

Closes #412

How to test the Change

This can be tested after the PR merge.

  • Verify that the "Generate release zip" action working fine.
  • Verify that the stable branch is updated with build files when we push anything to the trunk branch.
  • Verify that release zip archive to new release.

Changelog Entry

Changed - Updated release GH action workflow files.

Credits

Props @jeffpaul @ravinderk @dkotter @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh self-assigned this Aug 14, 2023
@iamdharmesh iamdharmesh added this to the 2.3.0 milestone Aug 14, 2023
@dkotter dkotter merged commit d4858c0 into develop Aug 14, 2023
12 of 13 checks passed
@dkotter dkotter deleted the enhancement/412 branch August 14, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update release process to attach ZIP archive to GH release
2 participants