Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the ClassifAI panel only appears when the related feature is enabled. #628

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

iamdharmesh
Copy link
Member

Description of the Change

PR fixes the issue reported in #627 and ensures that the ClassifAI panel only appears when the related feature is enabled and the user has access to a specific feature.

Closes #627

How to test the Change

  1. Uncheck the Classify content option for the NLU feature
  2. Check Enable role-based access
  3. Ensure your role is in the allowed list
  4. Go to a post and verify that the ClassifAI panel in the sidebar is not visible
  5. Verify that language-processing.css is not loaded

Changelog Entry

Fixed - Ensure that the ClassifAI panel only appears when the related feature is enabled.

Credits

Props @dkotter @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh self-assigned this Nov 29, 2023
@iamdharmesh iamdharmesh added this to the 2.5.0 milestone Nov 29, 2023
@dkotter dkotter merged commit 0c100ed into develop Nov 29, 2023
13 checks passed
@dkotter dkotter deleted the fix/627 branch November 29, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassifAI panel shows even if NLU feature is turned off
2 participants