Enhancement/566-2 Fix the Classification Popup after refactoring #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisal-alvi
requested review from
dkotter,
jeffpaul and
a team
as code owners
jeffpaul
requested review from
Sidsector9
and removed request for
a team and
jeffpaul
Sidsector9
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR fixes the issue in the pre-classification popup (#609) seen after the major refactoring (#611).
Basically re adds the function that was removed after refactoring merge and also updates the terms object to fetch the terms data.
Note: The PR branch is created from
classifai-non-react(i.e. #611) branch as per the internal discussion.Closes #
How to test the Change
Make sure the pre-classification popup works as expected.
Changelog Entry
Credits
Props @dkotter @faisal-alvi
Checklist: