Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-first refactor] Add support for role/user based access #635

Merged
merged 16 commits into from
Dec 21, 2023

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Dec 8, 2023

Description of the Change

PR adds support for role- and user-based access control to the ClassifiAI features. It also includes functionality for user-based opt-out, allowing users to choose not to use the specific feature if they prefer not to or if they dislike it.

This PR adds work of PR #606 to new feature-first refactoring branch.

How to test the Change

  1. Enable role-based access to the feature.
  2. Select roles in the allowed roles to provide access to that feature.
  3. Verify that only the selected roles have access to that feature.
  4. Enable user-based access to the feature.
  5. Select the user in the allowed users to provide access to that feature.
  6. Verify that the selected user has access to that feature.
  7. Enable user-based opt-out for the feature.
  8. Go to the user profile and verify that you see the checkbox for that feature to opt out of using it.
  9. Check the opt-out checkbox and save.
  10. Verify that access to that feature has been disabled.
  11. Uncheck the opt-out checkbox to opt back in to the feature.
  12. Verify that the user now has access to that feature.
  13. Follow these steps for each ClassifAI feature.

Changelog Entry

Added - Role and user-based access control for features

Credits

Props @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh self-assigned this Dec 8, 2023
@iamdharmesh iamdharmesh marked this pull request as ready for review December 14, 2023 09:05
@jeffpaul jeffpaul added this to the 3.0.0 milestone Dec 14, 2023
@jeffpaul jeffpaul removed their request for review December 14, 2023 14:26
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @iamdharmesh for accommodating these changes! Code looks good and tests well. Approving 👍

@Sidsector9 Sidsector9 merged commit 9ada3d8 into classifai-non-react Dec 21, 2023
1 check passed
@Sidsector9 Sidsector9 deleted the enhancement/access-control branch December 21, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants