Update 10up/phpcs-composer to version 3 and fix all newly flagged issues
#641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffpaul
requested review from
a team and
faisal-alvi
and removed request for
a team
faisal-alvi
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
@dkotter thanks for the PR. LGTM.
Tested features:
- ✅ Tagging
- ✅ Excerpt Generation
- ✅ Audio Transcripts
- ✅ Title Generation
- ✅ Expand or Condense Text
- ✅ Text to Speech
- ✅ Image Alt Text
- ✅ Image Tagging
- ✅ Generate Images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
We utilize the
10up/phpcs-composerpackage and it recently pushed out a major update to 3.0.0. This update brings in major updates from multiple other packages, including much better support for PHP 8+. As such we should be using this in our projects whenever possible.In making that update, lots of new issues were getting flagged which I've fixed in this PR. Majority of these are very minor things, like needing an extra space or deleting an extra space. But I know these sorts of fixes have caused problems in the past so definitely need a thorough eye on things here.
How to test the Change
Changelog Entry
Credits
Props @dkotter
Checklist: