Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-first refactoring] Update ClassifAI setup #642

Merged
merged 8 commits into from
Dec 21, 2023

Conversation

iamdharmesh
Copy link
Member

Description of the Change

PR refactors the existing ClassifAI setup (onboarding) to make it work with the new feature first refactoring. PR also improves the UI for the setup AI providers' step with new vertical tabs and status icons in it.

Screenshot 2023-12-15 at 5 14 08 PM

How to test the Change

  1. Make sure that ClassifAI setup process works fine and as expected.

Changelog Entry

Changed - Refactor ClassifAI setup for feature-first refactoring changes.

Credits

Props @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh self-assigned this Dec 15, 2023
@iamdharmesh iamdharmesh added this to the 3.0.0 milestone Dec 15, 2023
@iamdharmesh iamdharmesh marked this pull request as ready for review December 15, 2023 11:56
@jeffpaul jeffpaul removed their request for review December 15, 2023 14:16
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciating all your work for this refactor! Code looks good and tests well, approving 👍

@Sidsector9 Sidsector9 merged commit 1822cf1 into classifai-non-react Dec 21, 2023
1 check passed
@Sidsector9 Sidsector9 deleted the refactor-onboarding branch December 21, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants