Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP 5.2 version bump #67

Merged
merged 1 commit into from
May 22, 2019
Merged

WP 5.2 version bump #67

merged 1 commit into from
May 22, 2019

Conversation

jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented May 7, 2019

Description of the Change

@adamsilverstein tested in WordPress 5.2 RC and everything works as expected, so I'm adding a badge to note the WP version we're tested up to.

Alternate Designs

Open to other phrasings on the badge, but went with this option for now.

Benefits

Allows those browsing the repo to immediately see what version of WordPress we've tested up to.

Possible Drawbacks

Maybe some confusion that you need WP 5.2 in order to run ClassifAI?

Verification Process

I visually compared the README with the badge addition, looks good to me.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

n/a

@jeffpaul jeffpaul added the needs:documentation This requires documentation. label May 7, 2019
@jeffpaul jeffpaul requested a review from helen May 7, 2019 15:08
@jeffpaul jeffpaul self-assigned this May 7, 2019
@helen helen merged commit 16329ff into develop May 22, 2019
@jeffpaul jeffpaul added this to the 1.3.0 milestone Feb 26, 2020
@jeffpaul jeffpaul deleted the update/wp-version branch March 5, 2020 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:documentation This requires documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants