Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep/673: eliminate dead code #678

Merged
merged 11 commits into from
Feb 5, 2024
Merged

upkeep/673: eliminate dead code #678

merged 11 commits into from
Feb 5, 2024

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Feb 1, 2024

Description of the Change

This PR eliminates dead code.

Closes #673

How to test the Change

  • Ensure E2E tests pass
  • Verify with manual tests

Changelog Entry

Changed - Eliminate dead code

Credits

Props @dkotter @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@Sidsector9 Sidsector9 requested review from dkotter, jeffpaul and a team as code owners February 1, 2024 19:25
@Sidsector9 Sidsector9 removed request for a team, dkotter and jeffpaul February 1, 2024 19:25
@jeffpaul jeffpaul added this to the 3.0.0 milestone Feb 1, 2024
@Sidsector9 Sidsector9 changed the title [WIP]: upkeep/673: eliminate dead code upkeep/673: eliminate dead code Feb 2, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Feb 5, 2024
@dkotter dkotter merged commit 67a0165 into develop Feb 5, 2024
13 checks passed
@dkotter dkotter deleted the upkeep/673 branch February 5, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Clean up the Provider class a bit more
3 participants